Dear @skyjake I tried to compile Lagrange(1.9.5 git version) by myself in a Debian VM but the result was pretty bad.
The window is sluggish even with --sw options, the hamburger menu doesn't work.
I know this is a PEBCAK issue but what I don't know is where I should start to check for mistakes.
The Flathub version works just fine then is definitely a PEBCAK thing... 😅😅😅
1 year ago
@skyjake not I didn't figured it at all... 😅😅😅
Thanks for returning on this thread otherwise I wouldn't never realized it! 🤝 · 1 year ago
Ah, I wasn't notified of these because of the capital S in the @Skyjake — Station is case-sensitive with notifications.
You probably figured it out already but your -ENABLE options are a missing a D in the beginning. That is, they should be "-DENABLE_DOWNLOAD_EDIT=ON", etc. "-D" is CMake's "define" option.
Also, regarding turning off ENABLE_POPUP_MENUS: this should no longer be necessary in v1.10. I applied a workaround for the problem of menus not showing up. The only reason to disable the option is if the menu windows are not supported properly by SDL, like when running on Wayland. · 1 year ago
and...
$ cmake .. -DCMAKE_BUILD_TYPE=Release -ENABLE_DOWNLOAD_EDIT=ON -ENABLE_KERNING=ON -ENABLE_MPG123 -DENABLE_POPUP_MENUS=NO -DCMAKE_INSTALL_PREFIX=/usr/local/bin CMake Error: The source directory "/home/zagor/Git/lagrange/build/-ENABLE_MPG123" does not exist. Specify --help for usage, or press the help button on the CMake GUI. $ cmake .. -DCMAKE_BUILD_TYPE=Release -ENABLE_DOWNLOAD_EDIT=ON -ENABLE_KERNING=ON -ENABLE_MPG3 -DENABLE_POPUP_MENUS=NO -DCMAKE_INSTALL_PREFIX=/usr/local/bin CMake Error: The source directory "/home/zagor/Git/lagrange/build/-ENABLE_MPG3" does not exist. Specify --help for usage, or press the help button on the CMake GUI.
· 1 year ago
@Skyjake only issues I had on Devuan Chimaera were passing properly some options:
cmake .. -DCMAKE_BUILD_TYPE=Release -ENABLE_DOWNLOAD_EDIT=ON -ENABLE_KERNING=ON -ENABLE_MPG123=ON -DENABLE_POPUP_MENUS=NO -DCMAKE_INSTALL_PREFIX=/usr/local/bin $ cmake .. -DCMAKE_BUILD_TYPE=Release -ENABLE_DOWNLOAD_EDIT=ON -ENABLE_KERNING=ON -ENABLE_MPG123=ON -DENABLE_POPUP_MENUS=NO -DCMAKE_INSTALL_PREFIX=/usr/local/bin CMake Error: The source directory "/home/zagor/Git/lagrange/build/-ENABLE_MPG123=ON" does not exist. Specify --help for usage, or press the help button on the CMake GUI.
· 1 year ago
@Skyjake In my test over bare metal, Lagrange compiled by git on Devuan Chimaera does not have the issues with hamburger menu, hence I also think it may depends by a newer library. · 1 year ago
There's a potential fix in the dev branch now if you'd like to test it.
I managed to reproduce the issue in Debian 11 testing. Unfortunately, it seems like an SDL regression. · 1 year ago
https://github.com/skyjake/lagrange/issues/436 · 1 year ago
Same menu issue was just reported on Mastodon... On my Linux systems everything seems to be working fine, though. · 1 year ago
@Skyjake, even with the correct instructions still doesn't work the menu, however I wouldn't make you loosing time for nothing; this virtual machine is meant to play and to make test.
I'll try to a real hardware to verify if the issue still persist and I'll open a bug on gitea, in the meanwhile if you are just curious this is the output:
[command] {1} menu.open ptr:0x55fe4eee4d00
[command] {0} cancel
[command] {1} menu.opened ptr:0x55fe4eee4f10
[command] {1} menu.closed ptr:0x55fe4eee4f10
Thanks! · 1 year ago
🍻 · 1 year ago
@lykso thanks for helping me out... 🍺 · 1 year ago
@gnuserland You need to set your defines during the configuration step, not the build step. I.e., assuming you're in the Lagrange source directory:
$ rm -fr build
$ mkdir build
$ cd build
$ cmake .. -DENABLE_POPUP_MENUS=NO -DCMAKE_BUILD_TYPE=Release
$ cmake --build . · 1 year ago
Sorry that was a typo...
I swear I wouldn't bother you with this silly question if I was able to find out a dummy documentation.
However this is what I got:
cmake -DENABLE_POPUP_MENUS=NO --build . CMake Error: Unknown argument --build CMake Error: Run 'cmake --help' for all supported options.
@skyjake · 1 year ago
I think the first one should work, but it’s “POPUP” and not “POP” in the variable name.
Generally speaking, CMake is run first to generate the build files, and at this point you can set any options. Then you actually build the code using the generated files. This second step can be done manually (e.g., `make`) or via CMake itself (the --build option). The latter method is more portable. · 1 year ago
@skyjake this is something so trivial that is not explained anywhere... How should it be the right syntax?the following ones are wrong:
cmake -DENABLE_POP_MENUS=NO --build . cmake --build . -DENABLE_POP_MENUS=NO
🤷 · 1 year ago
Add `-DENABLE_POPUP_MENUS=NO` when you run CMake.
Running inside a VM may be related to the slowness, depending on what kind of virtual video driver it is using...? · 1 year ago
@Skyjake thanks for the suggestions.
CMAKE_BUILD_TYPE is set to release as for the documentation. I don't know how to pass ENABLE_POPUP_MENUS SDL should be enough recent since I am using Debian Testing!
· 1 year ago
Maybe these will help:
- Check that CMAKE_BUILD_TYPE is set to Release or RelWithDebInfo. When using a Git working copy it defaults to Debug.
- For the menus, try setting ENABLE_POPUP_MENUS to NO.
- Check if you're using a recent version of SDL (2.0.12+). It may be pretty old depending on which version of Debian you have. However, this should not affect performance that much. · 1 year ago
Sure but let see what Skyjake will say about the PEBCAK situation... 😂😂😂 · 1 year ago
My bet would be that you're missing some dependencies? Or using older versions of required packages maybe?
Just a guess tho, I bet skyjake will be able to help you, but you might want to create issue on github, would help in case other people experience this too. · 1 year ago