💾 Archived View for capsule.dotslashme.com › gemlog › posts › 2017-05-10-bang-youre-dead.gmi captured on 2024-05-12 at 15:03:23. Gemini links have been rewritten to link to archived content
⬅️ Previous capture (2024-02-05)
-=-=-=-=-=-=-
published on 2017-05-10
--//# best-practices # java # anti-patterns
In all code writing, there are quirks, shortcuts and disciplines that should absolutely be shunned as far as possible. One of these really bad practices is using the bang sign (!) to negate something, and besides the obvious, being hard to see at a quick glance, negations can impact readability quite a bit. Reading code should be fluent for several reasons, but mainly because interruptions or hiccups in the thought process will break the current train of thought.
if (!isContextPopulated) {
// Initialize context
}
Now be honest, if that comment weren't there, would you immediately grasp it's meaning, or would you have to read that if statement more than once?
Let me improve the readability a bit
if (isContextEmpty) {
// Initialize context
}
That's simpler to read, it's more fluent and you don't have to re-read it to understand it. If you did, you possibly think you missed the bang sign in front of it.
Have you ever come across something like this?
if (!isNotEmpty) {
}
This is a huge deal, you have to engage the logic center of the brain and interpret what it means, causing you to lose the train of thought immediately. Ultimately a huge time waster and a source of frustration.
The use of Boolean logic is great, but learn to use proper names for your variables. Name them for their intended use and if you find yourself writing the bang sign before the variable in your if's, rethink your name. If in doubt if it's readable or not, leave the code until next day and see if you can read it like a book.
© dotslashme