💾 Archived View for thebird.nl › gn-gemtext-threads › issues › dataset_queried_twice.gmi captured on 2023-06-14 at 14:14:05. Gemini links have been rewritten to link to archived content

View Raw

More Information

⬅️ Previous capture (2023-01-29)

-=-=-=-=-=-=-

Dataset Queried Twice

Tags

• assigned: alexm
• type: bug
• priority: medium
• keywords: performance enhancement, optimisation
• status: closed ,complete

Description

In the function

base.trait.create_trait

the dataset is queried twice:

• once in lines 30 to 33
• once in the call to GeneralTrait (line 42) - lines 67 to 74

Maybe, pass the dataset created in lines 30 to 33 to GeneralTrait to avoid re-querying the data.

Note 26/10/22

Pr that fixes the issue:

https://github.com/genenetwork/genenetwork2/pull/740