Awatmath.1777
net.bugs.4bsd
utcsrgv!utzoo!decvax!watmath!dmmartindale
Wed Feb 17 16:35:12 1982
spl bugs
Two raised-priority bugs in 4.1BSD:
========================================
SPL bug in clock.c.  You SHOULD fix this one immediately; it causes most of
softclock to run with interrupts locked out!
The differences dealing with the deletion of references to berknet in clock.c
were suggested by Berkeley in one of their mailings and are not important;
the critical one is the splx() added in the callout loop of softclock.

diff /usr/distr/4.1/sys/sys/clock.c clock.c
21d20
c_time > 0)
---
> 			if ((p1 = calltodo.c_next) == 0 || p1->c_time > 0) {
> 				splx(s);
192a193
> 			}
206d206
 0
212d211
b_flags |= B_WANTED;
  		sleep((caddr_t)bp, PRIBIO+1);
  	}
  	bp->b_error = 0;
  	bp->b_proc = u.u_procp;
  	bp->b_un.b_addr = u.u_base;

--- 713,719 -----
  		bp->b_flags |= B_WANTED;
  		sleep((caddr_t)bp, PRIBIO+1);
  	}
+ 	(void) spl0();
  	bp->b_error = 0;
  	bp->b_proc = u.u_procp;
  	bp->b_un.b_addr = u.u_base;

-----------------------------------------------------------------
 gopher://quux.org/ conversion by John Goerzen <jgoerzen@complete.org>
 of http://communication.ucsd.edu/A-News/


This Usenet Oldnews Archive
article may be copied and distributed freely, provided:

1. There is no money collected for the text(s) of the articles.

2. The following notice remains appended to each copy:

The Usenet Oldnews Archive: Compilation Copyright (C) 1981, 1996 
 Bruce Jones, Henry Spencer, David Wiseman.