Amputator has an overactive regex

https://i.redd.it/z8gc47o0cew81.png

created by WvBoyScouter on 29/04/2022 at 04:33 UTC

24 upvotes, 2 top-level comments (showing 2)

Comments

Comment by Killed_Mufasa at 29/04/2022 at 10:28 UTC

8 upvotes, 2 direct replies

Hi! Thx for submitting this bug report, much appreciated. This is one of those things I'm well aware of, but are quite difficult to fix properly. There have been cases where actual amp links have something like /ampsomewords in the url. So it's not so straightforward as to just make it a regex that that doesn't trigger when there are alphabetical characters after the amp string. I've recently taken some measures that prevent false positives on certain domains, but I'm kinda hesitant to go further than that, as it would be a lot of maintenance and it could cause false negatives. Personally I feel like it'a better to have false positives than false negatives, but that's a choice we could make.

Again, thx for pointing this out! Once I got some more time, I'll look into this more and run the numbers to see what measures make the most sense. Let me know if you have any more insights!

Comment by WvBoyScouter at 29/04/2022 at 04:35 UTC

3 upvotes, 0 direct replies

Original Post is on r/amateurradio https://www.reddit.com/r/amateurradio/comments/ue55ri/hey_ramateurradio_can_you_identify_this_cable/?utm_medium=android_app&utm_source=share