2018-09-20 Perl 6 Peer Review?

Does anybody feel like looking at my code and giving me some feedback? My main problem as a lone programmer is that I never know whether I’m doing it idiomatically. There’s no peer review when I’m working on my private projects away from the office.

Sometimes there’s no peer review when I’m working at the office, too. 😄

So, I’m guessing there are quite a few areas where I could use some help:

Better ways to write things using Perl 6
Better ways to write things using Cro
Better ways to write tests
Better ways to organize code
Better ways to document code
Better installation instructions
How to make this distributable via CPAN

Code:

git clone https://alexschroeder.ch/cgit/oddmuse6

#Oddmuse 6 #Perl 6

Comments

(Please contact me if you want to remove your comment.)

⁂

I made another reorganisation of the source code, trying to follow the instructions about distributing modules and thinking that the ultimate test would be to make a local installation. I somehow had the idea that this should work using `zef`:

distributing modules

zef install ./Oddmuse

But sadly, it doesn’t:

zef install ./Oddmuse
===> Testing: Oddmuse6:ver<0.0.1>:auth<kensanata>
===> Testing [OK] for Oddmuse6:ver<0.0.1>:auth<kensanata>
===> Installing: Oddmuse6:ver<0.0.1>:auth<kensanata>
===> Install [FAIL] for Oddmuse6:ver<0.0.1>:auth<kensanata>: ===SORRY!===
Could not find Oddmuse::View at line 18 in:
    /home/alex/rakudo/install/share/perl6/site
    /home/alex/rakudo/install/share/perl6/vendor
    /home/alex/rakudo/install/share/perl6
    CompUnit::Repository::AbsolutePath<94588950434432>
    CompUnit::Repository::NQP<94588953675624>
    CompUnit::Repository::Perl5<94588953675664>

===SORRY!===
Could not find Oddmuse::View at line 18 in:
    /home/alex/rakudo/install/share/perl6/site
    /home/alex/rakudo/install/share/perl6/vendor
    /home/alex/rakudo/install/share/perl6
    CompUnit::Repository::AbsolutePath<94588950434432>
    CompUnit::Repository::NQP<94588953675624>
    CompUnit::Repository::Perl5<94588953675664>

Now what?

– Alex Schroeder 2018-09-20 15:02 UTC

---

On `#perl6` I was given the solution: my `META6.json` was wrong.

1. I had a typo in the one file I had in the `provides` section

2. I was missing all the other files in the `provides` section

I definitely will need a tool to check this!

– Alex Schroeder 2018-09-20 18:23 UTC

---

I kept working on that `README` file and I think it’s looking good! Now I’ll wait for the confirmation mail from PAUSE so that I can upload it to CPAN. At least that’s the plan. And adding more features, of course. ☺

– Alex Schroeder 2018-09-20 19:21 UTC

---

Heh. And I found the offline Cro documentation in the form of Markdown files deep down in the `~/.zef` directory. That’s not as integrated as I would have liked but it works for me. And who knows, perhaps I’ll find the tool that allows me to browse it all.

– Alex Schroeder 2018-09-20 21:51 UTC

---

All these days have gone by and I didn’t get a reply from CPAN. No account created, I guess.

– Alex Schroeder 2018-09-26 21:46 UTC